feat: enable Codex subagent tool calls - #210
Merged
Merged
Conversation
Contributor
Author
|
Review/fix pass completed. No existing review comments were present. Fixed formatting noise in commit 098b030. Focused validation passed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex-subagent-tool-useshared message contract for official Codex subagent actions.function_callrows and app-serverdynamicToolCallrows into the typed message instead of external/unknown tool-use rows.Upstream Codex reference
Checked current
openai/codexmain via GitHub/clone ate0ac5d3c1552b4eb2c11d1f7e215bb933c78ad99.This PR does not enable subagent execution in a Codex runtime that lacks the collaboration tools. It makes Garcon typed/render-correct when Codex emits the upstream
spawn_agent,send_message,followup_task,wait_agent,interrupt_agent,list_agents,send_input,close_agent, orresume_agenttool calls.Screenshots
Desktop:
Mobile:
Validation
bun test server/agents/codex/__tests__/jsonl-tool-use-converter.test.js server/agents/codex/app-server/__tests__/app-server.test.jspasses: 52 tests.bun run --cwd web test -- src/lib/chat/__tests__/tool-roundtrip.test.ts src/lib/chat/__tests__/tool-display-registry.test.ts src/lib/components/chat/tools/__tests__/ChatToolEventRenderer.test.tspasses: 92 tests.bun run checkpasses: ESLint and Svelte check report 0 errors / 0 warnings.bun run start --port 0builds and starts a throwaway server athttp://0.0.0.0:41673; timeout then stops the foreground smoke process.bun run testis blocked by the existing Bun environment missingCompressionStream; failures are isolated toserver/lib/__tests__/http-compression.test.jscompression round-trip/skip-rule cases.Migration note
Known Codex subagent calls now cross the shared boundary as
codex-subagent-tool-useinstead ofexternal-tool-use/unknown-tool-use. Frontend behavior resolves by messagetypeand no client path keys off raw provider tool names for this family.Checklist