security: harden protocol parsing and resource limits#149
Open
zytakeshi wants to merge 2 commits into
Open
Conversation
The AEAD-2022 header timestamp validation used an asymmetric window:
up to 30 seconds in the past, but only 2 seconds in the future. SIP022
specifies a single tolerance ("not more than 30 seconds away"), applied
in both directions, and the 60-second salt replay cache is sized for a
±30s window.
The 2-second future cap rejected peers whose clock ran only slightly
ahead (NTP drift, unsynced/virtualized hosts), failing the handshake
with "timestamp is N seconds in the future" even though the spec would
accept anything within 30 seconds. Replace both request- and
response-header checks with a symmetric abs_diff > 30 check.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
9096ce4 to
7f145b8
Compare
7f145b8 to
618ff45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Verification
Notes