CFE-2815: Added isnewerthantime function
#5799
Conversation
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| int exit_code = stat(arg_file, &file_buf); | ||
|
|
||
| if (exit_code == -1) | ||
| { |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
|
|
||
| time_t file_mtime = file_buf.st_mtime; | ||
|
|
||
| bool result = file_mtime > arg_mtime; |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
| time_t file_mtime = file_buf.st_mtime; | ||
|
|
||
| bool result = file_mtime > arg_mtime; | ||
|
|
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
|
|
||
| bool result = file_mtime > arg_mtime; | ||
|
|
||
| return FnReturnContext(result); |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
| bool result = file_mtime > arg_mtime; | ||
|
|
||
| return FnReturnContext(result); | ||
| } |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
|
|
||
| return FnReturnContext(result); | ||
| } | ||
|
|
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
There was a problem hiding this comment.
Great work!
Since the title will be part of the changelog you can make it a little bit more specific. E.g., "Added isnewerthantime() policy function". Also backticks in the changelog can cause som issues later on. So better omit them in the case of changelog entries.
It would also be nice if you included an acceptance test. Here you can add more test cases that are not suitable in an example. E.g., what happens if the timestamp is not a string, what happens in the timestamp is CF_NOINT, what happens if timestamp is CF_INFINITY etc.
|
You will also have to sign the CLA #5799 (comment) |
Changelog: None Signed-off-by: jakub-nt <[email protected]>
Ticket: CFE-2815 Changelog: Title Signed-off-by: jakub-nt <[email protected]>
corresponding docs PR: cfengine/documentation#3430