ENT-13699: Immediately collect report on bootstrap #6041
+39
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made LastSaw1() return bool indicating new host and notify enterprise on first auth. Ticket: ENT-13699 Signed-off-by: Lars Erik Wik <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| LastSaw1(conn->ipaddr, KeyPrintableHash(ConnectionInfoKey(conn->conn_info)), | ||
| LAST_SEEN_ROLE_ACCEPT); | ||
| bool is_new_host = LastSaw1( | ||
| conn->ipaddr, |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
| LAST_SEEN_ROLE_ACCEPT); | ||
| bool is_new_host = LastSaw1( | ||
| conn->ipaddr, | ||
| KeyPrintableHash(ConnectionInfoKey(conn->conn_info)), |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
| { | ||
| NotifyNewHostSeen( | ||
| KeyPrintableHash( | ||
| ConnectionInfoKey(conn->conn_info))); |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
(@craigcomstock had to rebuild due to some CI issues): Jenkins: https://ci.cfengine.com/job/pr-pipeline/13377/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13377/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made LastSaw1() return bool indicating new host and notify enterprise on first auth.
Merge together with: