-
Notifications
You must be signed in to change notification settings - Fork 197
Make timestamp formatting consistent #6042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Use %jd to get the timestamp like other functions do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable. Thanks for the contribution. Hope your ARMv7 systems are doing well.
|
Fixed other similar warnings (although less serious) with the same change for consistency. |
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13376/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13376/ |
Use
%jd+intmax_tto format the timestamp (like othertime_tformats do) in file backup code.On ARMv7 (which is, understandably, unsupported) it segfaults at runtime. But formatting a (signed)
time_tas unsigned is, AFAIK, undefined behavior annyway.