Skip to content

fix(merge_clippings): insert a space between adjacent clippings#14

Merged
cfm merged 1 commit into
mainfrom
11-whitespace
Mar 29, 2026
Merged

fix(merge_clippings): insert a space between adjacent clippings#14
cfm merged 1 commit into
mainfrom
11-whitespace

Conversation

@cfm

@cfm cfm commented Mar 29, 2026

Copy link
Copy Markdown
Owner

Fixes #11.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Issue #11 by ensuring that when two highlights from the same book are merged due to contiguous locations, the resulting merged body preserves a separating space instead of concatenating words.

Changes:

  • Insert a space when merging clippings whose location_end matches the next clipping’s location_start.
  • Add a regression test covering adjacent-location merging where whitespace would otherwise be lost.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main.rs
@cfm cfm merged commit b11f290 into main Mar 29, 2026
5 checks passed
@cfm cfm deleted the 11-whitespace branch March 29, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adjacent-clip concatenation loses whitespace

2 participants