Skip to content

Add rate-explorer tests for some dynamic content - #7633

Closed
anselmbradford wants to merge 22 commits into
mainfrom
ans_oah_tests
Closed

Add rate-explorer tests for some dynamic content#7633
anselmbradford wants to merge 22 commits into
mainfrom
ans_oah_tests

Conversation

@anselmbradford

@anselmbradford anselmbradford commented Mar 29, 2023

Copy link
Copy Markdown
Member

Touching rate-explorer scares me, let's have some tests for the dynamically displayed drop-downs and alerts.

Additions

  • Add a few more rate-explorer tests to test the different loan types dynamic drop-downs and alerts.

How to test this PR

  1. yarn cypress open to test manually.
  2. PR checks should pass.

@anselmbradford

Copy link
Copy Markdown
Member Author

So turns out this is blocked by there not being example data for the rate checker API in our test data, which is what the Cypress tests run against in GitHub Actions.

@anselmbradford

Copy link
Copy Markdown
Member Author

Use [ghe]/OAH/OAH-notes/wiki/Explore-Rates-high-balance-logic as a guide to building out test suite.

@anselmbradford

Copy link
Copy Markdown
Member Author

Flagging @wpears and @mistergone if they get into adding additional test data to rate-explorer and need some tests.

@anselmbradford

Copy link
Copy Markdown
Member Author

Closing this because Rate Explorer has been removed in #9011 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants