Remove google optimize legacy code cruft and AB_TESTING flag - #8862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google Optimize settings were added in #7444, however, since that time Google Optimize has been sunset https://support.google.com/analytics/answer/12979939?hl=en
This PR removes the references to
optimize.google.comandgoogleoptimize.com. Additionally, it removes theAB_TESTINGflag.Removals
AB_TESTINGoptimize flag.How to test this PR
Notes
I left the
fonts.gstatic.comsettings, since they may be used by google analytics too (not sure if they actually are).Todo
Follow the Feature Flag hygiene instructions after this is merged https://cfpb.github.io/consumerfinance.gov/feature-flags/#hygiene