Encode meta descriptions for search.gov - #8865
Merged
Merged
Conversation
chosak
reviewed
Jul 9, 2025
chosak
left a comment
chosak
left a comment
Member
There was a problem hiding this comment.
This is clever! Would you mind adding a unit test for this?
Co-authored-by: Andy Chosak <andy.chosak@cfpb.gov>
Member
Author
I was kinda hesitant to test this since it kinda seemed like I was just testing that |
Member
|
Very nifty idea! 🥳 |
mistergone
approved these changes
Jul 14, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search.gov lowercases all custom data (an acknowledged bug) and also splits on commas. This base32 encodes our meta descriptions such that these behaviors are ameliorated.
There will be a follow-up PR that decodes and uses these descriptions.
This PR also bumps the sitemap min date to today to trigger a recrawl from search.gov