Migrate svg_icon middleware to return web component - #9132
Conversation
5f2c897 to
8123d8e
Compare
8123d8e to
8e34285
Compare
|
I notice that the icons in grad path seem to be ~4px lower than on prod. Is that intentional/known? |
Hmm which icons? I didn't see a 4px offset, but I did notice I needed to add temporary styles for the wc icon inside the non-wc form alert, which can be removed if/when the alert is moved to a wc. 57df3f1 |
Huh, I retested and this is gone, maybe I hadn't hard refreshed. Sorry for the noise! |
|
I will note, though, that on http://localhost:8000/rural-or-underserved-tool/ if you show / hide the map, after once cycle "show map" no longer gets the + icon. |
Fixed in ade7a8b I noticed that the show/hide toggle link has a |
|
Pushed up a little change in b971470 because I realized you can click in the gap between the text and icon and throw things off. |
|
Heading out on OOO. Feel free to merge this in if the bewds are good with the backend changes ✌️ 🇺🇸 ✌️ |
# Conflicts: # cfgov/unprocessed/js/routes/common.js
# Conflicts: # cfgov/unprocessed/js/routes/common.js
Co-authored-by: Andy Chosak <andy.chosak@cfpb.gov>
Co-authored-by: Andy Chosak <andy.chosak@cfpb.gov>
Co-authored-by: Andy Chosak <andy.chosak@cfpb.gov>
Co-authored-by: Andy Chosak <andy.chosak@cfpb.gov>
Changes
How to test this PR
yarn buildand places where the icon appears should look the same as the production site.In particular:
Follow the directions in SVG icons as a button in the Draftail rich text editor #8488 and see that you can still add an icon in Wagtail.
Visit http://localhost:8000/paying-for-college/your-financial-path-to-graduation/ and see that the tooltips still have icons.
Icons are correct on http://localhost:8000/consumer-tools/educator-tools/youth-financial-education/teach/activities/
Spinning update icon, and show/hide map icon on http://localhost:8000/rural-or-underserved-tool/