Conversation
itsmedavep
changed the title
natalia-fitzgerald
left a comment
natalia-fitzgerald
left a comment
There was a problem hiding this comment.
Nice work @itsmedavep! It's great to see this taking shape. I added some suggestions for your consideration as well as some questions about the process.
| - Add any data or research you have to show that the proposed change is accessbile and usable | ||
| - Supply any design and development context for your request you may have (e.g. Figma concepts, code samples, etc) | ||
| - Include if you can design and build the proposed change or if you will need to request that someone makes the changes for you | ||
| - Draft documentation for the proposed change to be included in the Design System website (can be included in this issue or in the comments) |
There was a problem hiding this comment.
| - Draft documentation for the proposed change to be included in the Design System website (can be included in this issue or in the comments) | |
| - Provide documentation for the proposed change that will be included on the Design System webpage (this can be added here or as a comment) |
|
|
||
| **What kind of issue is this?** | ||
| Add one or more of the issue labels below to the right-hand sidebar AND issue title. | ||
| (We strongly encourage you to make content changes yourself where possible!) |
There was a problem hiding this comment.
| (We strongly encourage you to make content changes yourself where possible) |
There was a problem hiding this comment.
What does this mean? Should a person still submit this ticket for tracking purposes even if they intend to ultimately implement the changes?
In the past I have used this issue template to suggest changes or flag content issues in order to get the thumbs up to correct them (even if I ultimately do the legwork of correcting myself)
There was a problem hiding this comment.
AFAIK this was existing language in the issue template. The only change that I made here was to update the name of the issue template and remove references to an employee no longer with the Bureau.
Presumably the old workflow as intended to make visible if someone inside the bureau had made a change BUT that project board is giving 404. I'll just remove the ref.
| @@ -32,4 +32,3 @@ | |||
| ***Thanks. Don't forget to add labels indicating issue type and size before submitting!*** | |||
| ***Once you've submitted your issue, please add it to the content backlog project board: https://github.com/cfpb/design-system/projects/1*** | |||
There was a problem hiding this comment.
"Once you've submitted your issue, please add it to the content backlog project board: https://github.com/cfpb/design-system/projects/1"
I haven't done this before. Is this something that I should be doing?
There was a problem hiding this comment.
See previous comment about this but it looks to be referencing an old workflow that isn't applicable now. I've removed this.
There was a problem hiding this comment.
Is this the current process - to discuss in Hubcap? Can we change this to be a discussion in the DS itself? Or is there another place? I don't think discussions are happening in Hubcap.
There was a problem hiding this comment.
Good point. The discussions should happen in the issue you create presumably.
"Remember, new standards should be discussed in this GitHub first before being added to the Design System. "
Updated.
itsmedavep
dismissed
natalia-fitzgerald’s stale review
I manually updated these instead of approving the commits. I didn't realize I could and hand edited about 3/4 of them. Regardless the changes are in the files now and your request is changed to comments in the thread. Sorry about that.
3 participants
[Short description explaining the high-level reason for the pull request]
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Browsers
Accessibility
Other