Support multiple settings-based sharing hosts - #79
Merged
Conversation
This change modifies the behavior of the WAGTAILSHARING_HOST setting, when used with the SettingsHostRouter router. Instead of specifying a single sharing host, it's now possible to specify multiple sharing hosts, either as a list or as a single comma-delimited string. This supports testing of wagtail-sharing where you may have multiple domains, say, one for internal testing and one that is public-facing.
willbarton
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies the behavior of the
WAGTAILSHARING_HOSTsetting, when used with the SettingsHostRouter router. Instead of specifying a single sharing host, it's now possible to specify multiple sharing hosts, either as a list or as a single comma-delimited string.This supports testing of wagtail-sharing where you may have multiple domains, say, one for internal testing and one that is public-facing.