Skip to content

fix compile error in ngx_stream_limit_upstream_module.c and core dump… #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ppliu1979
Copy link

fix compile error in ngx_stream_limit_upstream_module.c and core dump caused by ngx_del_timer.
add patch of version 1.14.2

@cfsego
Copy link
Owner

cfsego commented Jul 5, 2019

I hope you make some modifications to your patch, and I will merge it absolutely.

  1. There is no compile error. You should patch nginx-1.12.1.patch first, and then nginx-1.12.1-stream.patch if you want to use it with stream module. I tested it on nginx-1.14, there was no compile error.
  2. ngx_del_timer is a real bug, and thank you for fixing it. plz delete this line, but not only comment it.

thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants