[pull] master from microsoft:master#44
Merged
Merged
Conversation
The verbs 'clone', 'mount', 'prefetch', and 'cache-server' each perform a query to gvfs/config endpoint for two purposes: to get the list of allowed client versions for the server, and to get the list of preconfigured cache servers. Currently, if the query fails then the verb fails. The most common reason for the query to fail appears to be transient network/authentication issues, making automount in particular more flaky than desired. Mount and Prefetch verbs should always have a cache server configuration available already, and Clone and Cache-Server both have command-line options to allow specifying the cache server configuration. This change modifies the verbs so that if a cache server url is already available (from local config or command-line option) then the verb will warn that the version could not be checked and continue instead of failing if the query to gvfs/config fails.
In some environments "gvfs" may not be properly resolved by the shell when running the background prefetch process, so this change uses the current process path instead. If the background prefetch process fails to start, the error is now displayed to the user with remediation steps and clone continues to the next step.
Handle errors on background prefetch start
Warn-and-continue if gvfs/config download fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )