[pull] master from microsoft:master#80
Merged
Merged
Conversation
Git fires the post-index-change hook for every index write, including temp indexes created via GIT_INDEX_FILE redirect (e.g. read-tree --index-output, git add with a temp index). The GVFS mount process only needs to know about changes to the real `\$GIT_DIR/index`. When writing a 194MB temp index (2.47M entries), the hook's pipe round-trip to the GVFS mount process adds ~5s of overhead per read-tree/add call — a significant regression for tools that use the temp-index flow. Add an early-exit check in IsNonCanonicalIndex() that resolves both GIT_INDEX_FILE and `\$GIT_DIR/index` to absolute paths via GetFullPathNameA, then compares case-insensitively. If they differ, the hook exits immediately without contacting the mount process. When the environment is unexpected (GIT_DIR absent, path resolution fails), we err on the side of correctness and proceed with the notification rather than silently suppressing it. Unit tests invoke the hook exe with controlled environment variables and WorkingDirectory set to %TEMP% (outside any GVFS mount) to verify: - temp index paths (should skip) - canonical index paths (should NOT skip, exits NotInGVFSEnlistment) - missing GIT_DIR (should NOT skip) - mixed separators and case (normalization via GetFullPathNameA) Note: the ideal long-term fix is in Git's do_write_locked_index() (read-cache.c) to skip firing the hook entirely for non-default indexes, avoiding the process spawn altogether. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
…temp-index PostIndexChangedHook: skip notification for non-canonical indexes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )