[pull] master from microsoft:master#85
Merged
Merged
Conversation
Replace reflection-based CommandLineParser 2.6.0 with Microsoft's System.CommandLine 2.0.5 stable release. This eliminates runtime reflection for CLI parsing, a prerequisite for NativeAOT compilation. All 16 GVFS verbs, FastFetch, GVFS.Mount, and LockHolder migrated. Uses SetAction+ParseResult pattern (2.0.x stable API). Shared helpers in GVFSVerb reduce boilerplate while preserving per-verb option binding. Replaces System.CommandLine's built-in --version (assembly reflection, not AOT-safe) with custom --version option routing to same code as 'gvfs version' subcommand via ProcessHelper.GetCurrentProcessVersion(). Adds 'help' subcommand for backward compatibility with old CLI. Case-insensitive verb matching preserved via args normalization. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Migrate from CommandLineParser to System.CommandLine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )