[pull] master from microsoft:master#90
Merged
Merged
Conversation
The StatusTests WriteWithoutClose and CreateFileWithoutClose tests intentionally open file handles without closing them, then validate git status behavior. The handles were created as local variables inside OpenFileAndWriteWithoutClose/CreateFileWithoutClose with no reference kept — making them eligible for GC immediately. If the GC collected the handles before TearDown ran git reset --hard, the reset would succeed (no lock errors) while the control repo might still have errors, causing a flaky mismatch. Fix: return IDisposable from the file-handle-leaking methods, hold them in using blocks in the test methods. Handles stay alive for the assertion scope and are deterministically disposed before TearDown runs, eliminating the GC race. Also add StreamWriter.Flush() to ensure written data is on disk before returning. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
…lose Fix flaky WriteWithoutClose/CreateFileWithoutClose functional tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )