removal of hmmlearn in favour of pomegranate #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 14, 2019 12:50
Now use DiscreteDistribution from `pomegranate` Fixed order issue that cuased error if is_accessible was left as None.
Previous issue has been resolved jmschrei/pomegranate#532
hardingnj
commented
May 14, 2019
| @@ -258,15 +267,6 @@ def roh_poissonhmm(gv, pos, phet_roh=0.001, phet_nonroh=(0.0025, 0.01), transiti | |||
| return df_roh[["start", "stop", "length", "is_marginal"]], froh | |||
|
|
|||
|
|
|||
| def _mhmm_derive_emission_matrix(het_px, p_accessible): | |||
There was a problem hiding this comment.
No longer required with DiscreteDistribution
|
Still running into this pomergranate |
|
Just noting that pomegranate install issues should have been resolved. No urgency but would be nice to revisit this PR at some point :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #218 dependency on hmmlearn