Add more hooks #27
Open
Add more hooks #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robko23
reviewed
Feb 10, 2023
Comment on lines
+194
to
+204
| for proj_id in &self.proj_writes { | ||
| if let Some((root, hooks)) = args.hooks.get(proj_id) { | ||
| hooks.execute_pre_begin(root)?; | ||
| } | ||
| } | ||
|
|
||
| for proj_id in &self.proj_writes { | ||
| if let Some((root, hooks)) = args.hooks.get(proj_id) { | ||
| hooks.execute_pre_write(root)?; | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we really need two hooks that are in the same place but different name?
There was a problem hiding this comment.
It does seem a little weird, but the idea is that the hooks are semantically different. Long term goal would be that the pre-begin hook runs on all projects on every release, whereas the pre-write hook runs only on projects that actually will write something. Also, if there later exists some hook-able action that occurs before write, the pre-write hook will come after that, but pre-begin will still come before it. Finally, because hooks are all run together, this will give a user to have some control over when their hooks will run in relation to each other.
Comment on lines
+343
to
+353
| for proj_id in &self.write.proj_writes { | ||
| if let Some((root, hooks)) = args.hooks.get(proj_id) { | ||
| hooks.execute_post_tag(root)?; | ||
| } | ||
| } | ||
|
|
||
| for proj_id in &self.write.proj_writes { | ||
| if let Some((root, hooks)) = args.hooks.get(proj_id) { | ||
| hooks.execute_post_end(root)?; | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds additional hooks to the runtime, which (just like the existing
post_writehook) will not run on a dry run.Hooks added: