chore: update manifest mainnet info#1480
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7429c5747c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }, | ||
| { | ||
| "coinDenom": "PWR", | ||
| "coinMinimalDenom": "factory/manifest1afk9zr2hn2jsac63h4hm60vl9z3e5u69gndzf7c99cqge3vzwjzsfmy9qj/upwr", |
There was a problem hiding this comment.
This adds PWR under a token-factory denom, but Manifest's own current integrator examples use bare upwr for PWR amounts/SKU prices, and the live asset index for Manifest lists well-known native coins plus factory denoms without this exact factory/.../upwr asset. With this value, Keplr will look up and construct fee payments for a different denom than the PWR balances users actually need, so PWR balances/fees will not work as intended. Please register the actual on-chain PWR base denom instead of this factory path.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Is there a reason coinMinimalDenom is a factory token and not just upwr?
There was a problem hiding this comment.
@dogemos it's how it was created on-chain. The PWR denom is a factory denom controlled by the POA group.
2 participants
Changes
Checklist
yarn validate <your-config-file>locally, and it passed without any errors.