Make PR validation safe for external forks#1490
Draft
piatoss3612 wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_request_targetfrom the trusted base checkout instead of executing PR-controlled workflow/code by default..github/**,src/**,package.json, oryarn.lock.Why
First-time external contributors currently need a maintainer to approve the workflow before they can get validation feedback. This keeps the common data-only registry PR path automatic while avoiding untrusted PR code execution.
Validation
bash -n .github/scripts/safe-pr-validation.shgit diff --checkyarn tsc --noEmit --pretty falseyarn lint:test.github/workflows/pull-request-validation.ymlMaintainer review requiredPRICE_URL: price endpoint failure matched inconclusive classification