Skip to content

Make PR validation safe for external forks#1490

Draft
piatoss3612 wants to merge 1 commit into
mainfrom
codex/safe-pr-validation
Draft

Make PR validation safe for external forks#1490
piatoss3612 wants to merge 1 commit into
mainfrom
codex/safe-pr-validation

Conversation

@piatoss3612

Copy link
Copy Markdown
Member

Summary

  • Change PR validation to run on pull_request_target from the trusted base checkout instead of executing PR-controlled workflow/code by default.
  • Add a safe validation script that overlays only registry data/image changes from the PR head before running the existing validator.
  • Require maintainer review for external PRs that touch validator, dependency, or workflow files such as .github/**, src/**, package.json, or yarn.lock.
  • Classify transient public price endpoint failures separately from hard validation errors and report validation results through a sticky PR comment/job summary.

Why

First-time external contributors currently need a maintainer to approve the workflow before they can get validation feedback. This keeps the common data-only registry PR path automatic while avoiding untrusted PR code execution.

Validation

  • bash -n .github/scripts/safe-pr-validation.sh
  • git diff --check
  • yarn tsc --noEmit --pretty false
  • yarn lint:test
  • YAML parse check for .github/workflows/pull-request-validation.yml
  • Dry-run against real PR refs without posting comments:

@vercel

vercel Bot commented Jun 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
keplr-chain-registry Ready Ready Preview, Comment Jun 8, 2026 7:34am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant