add IslamicChain mainnet registry entry#1498
Conversation
feat(islamicchain): add IslamicChain mainnet registry entry
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f921339fb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -0,0 +1,40 @@ | |||
| { | |||
There was a problem hiding this comment.
Put IslamicChain under a loaded registry directory
This adds the chain as islamicchain/chain.json, but the repo only validates and serves files from cosmos/**, evm/**, and svm/**: the PR workflow filters to those paths, build:server/bundle:server copy only those directories, and loadChains() reads static/cosmos, static/evm, and static/svm. In this location the new entry is skipped by CI and never included in the API response, so users will not be able to add IslamicChain; it needs to be converted to this repo's cosmos/islamicchain.json Keplr format (with images under images/islamicchain/) instead of the chain-registry chain.json/assetlist.json layout.
Useful? React with 👍 / 👎.
add islamicchain mainnet registry
feat(islamicchain): add IslamicChain mainnet registry entry
Changes
Checklist
yarn validate <your-config-file>locally, and it passed without any errors.