-
Notifications
You must be signed in to change notification settings - Fork 532
ModularChainInfo: branch for merge #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
editaahn
wants to merge
96
commits into
develop
Choose a base branch
from
editaahn/refactor-modular-merge
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sic-updates ModularChainInfo 타입 수정 / stores, background 내부의 modularChainInfos 데이터 가공 시 분기
piatoss3612
reviewed
Dec 18, 2025
| const modularChainInfo = | ||
| this.chainsService.getModularChainInfoOrThrow(chainId); | ||
|
|
||
| if ("evm" in modularChainInfo) { |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Thunnini finalizeKeyCoinType 메서드에서 evm을 먼저 검사하면 ethermint, cosmos/evm 체인에서 문제가 되지 않을까요?
9631e19 to
20f8000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear KEPLR-1305
배경
multichain ecosystem에 맞춘 코드 베이스로 개선
진행 상태
예정 timeline
변경 사항 요약
ModularChainInfo타입 확장 codeevm추가 (as-is: EVM 체인도cosmos타입을 사용하고 있었음)isNative: 기존 ChainInfo 타입에서는 native 체인 여부를 알기 위해 embedded.embedded 또는 beta 필드 사용 -> ModularChainInfo에서는isNative라는 이름으로 통합logic 상 분리: EVM <> Cosmos
ModularChainInfoImpl확장 및 메서드 최적화 codepackages/stores/src/chain/base.tsChainInfo -> ModularChainInfo 사용부 legacy 전면 교체
getChain->getModularChainorgetModularChainInfoImplhasChain->hasModularChainormatchModuleschainInfos->modularChainInfoschainInfosInUI->modularChainInfosInUI분기가 필요한 경우는 “cosmos”, “evm”, “bitcoin” 등의 객체 존재 여부로 확인하시거나,
getModularChainInfoImpl(chainId).matchModule(“cosmos”)getModularChainInfoImpl(chainId).matchModules({ or: [“cosmos”, “evm”] })등을 사용해주세요.기타 참고사항
experimentalSuggestChain같은 method는 기존 legacy ChainInfo를 사용해야함packages/common추가 (convertModularChainInfoToChainInfo) codeuseGetAllNonNativeChain)History: 아래 PR들이 합쳐짐
ModularChainInfo 타입 수정 / stores, background 내부의 modularChainInfos 데이터 가공 시 분기 #1590
[Ext] cosmos <> evm 모듈 상세 로직 분기: Balance 조회 및 Custom token 관리 #1597
[Ext] cosmos <> evm 모듈 상세 로직 분기: 세부 기능 별 분기 #1606
add methods to
ModularChainInfoImpland refactor #1607replace legacy ChainInfo #1619
머지 충돌 해결 / 후속 빌드 애러 해결