Skip to content

Conversation

@kws1207
Copy link
Collaborator

@kws1207 kws1207 commented Jan 30, 2026

이벤트 시트 링크 및 테스트 결과 링크는 리니어 티켓에 있습니다.

@kws1207 kws1207 self-assigned this Jan 30, 2026
@kws1207 kws1207 requested a review from a team as a code owner January 30, 2026 13:33
@vercel
Copy link

vercel bot commented Jan 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
keplr-wallet-extension Ready Ready Preview, Comment Jan 30, 2026 2:01pm

Request Review

case SwapV2TxStatus.UNKNOWN: {
analyticsAmplitudeStore.logEvent("swap_v2_history_unknown", {
...baseEventData,
});
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프라이버시 문제로 tx hash는 baseEventData에서는 제외했는데, 예외적으로 unknown 케이스에만 tx hash를 수집할지 고민됩니다.

Move shared analytics properties (in_coin_denom, out_coin_denom,
route_duration_estimate_sec, is_only_bridge) to baseEventData to
reduce duplication and include them in UNKNOWN status events.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants