[🎨 Design System] Clean up sync scripts and typography types#1901
Merged
[🎨 Design System] Clean up sync scripts and typography types#1901
Conversation
- Fix dark-mode-first bias: include tokens present in either mode - Remove hardcoded black/white — derive from Figma or add as synthetic fallback - Replace L.push() pattern with template literal for readability - Fix Figma file name in generated header Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…Size - Rename type to better reflect its purpose (size selection) - Fix Figma file name in generated header Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Re-generate color.ts and typography-tokens.ts with updated scripts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jungcome7
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jungcome7
changed the title
Storybook 배포 완료🔗 미리보기: https://chainapsis.github.io/keplr-wallet/storybook/ Last updated: 2026-03-30T05:42:30Z |
Contributor
Author
|
@codex review |
piatoss3612
reviewed
Mar 30, 2026
| @@ -1,6 +1,6 @@ | |||
| // GENERATED FILE — DO NOT EDIT MANUALLY | |||
Member
There was a problem hiding this comment.
color.ts에는 @generated라고 되어있는데, 이 파일에는 GENERATED FILE이라고 되어있습니다. 한 가지 방식으로 통일해서 일관성을 주면 좋을 것 같습니다. 한 번 체크해주세요
Contributor
Author
There was a problem hiding this comment.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jungcome7
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
…iteral - Replace lines.push() pattern with single template literal - Rename sizeToDartField → sizeToTsField Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jungcome7
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
Contributor
Author
|
추가로 generate-typography-ts도 |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jungcome7
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
piatoss3612
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1. generate-color-ts 스크립트 개선
black/white하드코딩 제거 → Figma에서 가져오거나 synthetic fallbackL.push()→ 템플릿 리터럴로 전환2. DSTypographyTokensKey → DSTypographySize
3. 토큰 재생성
4. generate-typography-ts 스크립트 개선
lines.push()→ 템플릿 리터럴 전환,sizeToDartField→sizeToTsField리네이밍, 생성 파일 헤더GENERATED FILE로 통일Test plan
sync:tokens전체 파이프라인 통과typecheck통과🤖 Generated with Claude Code