[🎨 Design System] Storybook showcase + theme switching by jungcome7 · Pull Request #1904 · chainapsis/keplr-wallet

jungcome7 · 2026-03-30T05:52:29Z

#1900 과 동일한 내용입니다. base 브랜치가 먼저 머지되면서 누락되어 다시 올립니다.

추가 수정

stories + preview.tsx에 import React 누락 수정
Vite esbuild JSX transform을 classic으로 설정 (tsconfig jsx: "react"와 일치)
Typography story export name을 Showcase → Typography로 변경 (Color, Icon과 URL 패턴 통일)

🤖 Generated with Claude Code

vercel · 2026-03-30T05:52:34Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
keplr-wallet-extension	Ready	Preview, Comment	Mar 30, 2026 7:45am

github-actions · 2026-03-30T05:54:37Z

Storybook Deployed

🔗 Preview: https://chainapsis.github.io/keplr-wallet/storybook/

Last updated: 2026-03-30T07:45:25Z

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e5e2b4e731

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-30T05:57:22Z

+export const Overview: StoryObj = {
+  name: "Overview",
+  render: () => (
+    <div


Import React in new Storybook JSX files

These new Storybook files render JSX without importing React (components.stories.tsx, color.stories.tsx, icon.stories.tsx, and .storybook/preview.tsx), but this package still uses the classic runtime (packages/design-system/tsconfig.json sets "jsx": "react"). In that mode, yarn workspace @keplr-wallet/design-system typecheck fails with TS2874 (React must be in scope), so this commit introduces a typecheck break for the design-system workspace unless each JSX file imports React (or the tsconfig runtime is migrated).

Useful? React with 👍 / 👎.

stories 3개 + preview.tsx에 import React 추가했습니다. typecheck 통과 확인.

- Color / Typography / Icon 쇼케이스 stories - addon-themes: 툴바에서 Light/Dark 전환 + 배경색 자동 전환 - preview: DSThemeProvider + DSColor.background.surface.ground 배경 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Configure Vite esbuild to use classic JSX transform to match tsconfig's jsx: "react" setting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…stency Also restore DSTypographyTokensKey reference to match current tokens file. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…n stories Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

jungcome7 · 2026-03-30T06:53:42Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff76c838a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-30T07:02:45Z

+"react@npm:^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0":
+  version: 19.2.4
+  resolution: "react@npm:19.2.4"


Align Storybook docs with workspace React major

This lockfile change introduces a second React major (19.2.4) for the Storybook docs dependency range while the repo is still pinned to React 18, so Storybook can end up loading docs blocks with a different React instance than the preview renderer. In that mixed-major setup, docs pages commonly fail at runtime with Invalid hook call when rendering stories/components together, which would break Storybook preview/deployment for this package.

Useful? React with 👍 / 👎.

수정했습니다. root resolutions에 react/react-dom을 ^18.2.0으로 추가하여 18.3.1로 통일했습니다.

→ 1aa6445

Add react/react-dom resolutions to pin workspace to React 18, preventing yarn from resolving addon-docs peer dep to React 19. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

piatoss3612 · 2026-03-30T07:27:44Z

+      storySort: {
+        order: [
+          "Foundations",
+          ["Color", "Icon", "Typography", ["Docs", "Showcase", "Playground"]],


실제 export 이름은 Typography로 되어있는데 여기는 Showcase로 되어 있어서 매칭이 안되네요. 사이드바에서 무시가 되기는 하는 거 같은데 그래도 매칭시켜주는 게 좋을 거 같습니다.

그러네요. 수정했습니다!

fix(design-system): align storySort with renamed Typography story

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

piatoss3612

👍

jungcome7 requested a review from a team as a code owner March 30, 2026 05:52

jungcome7 temporarily deployed to github-pages-preview March 30, 2026 05:52 — with GitHub Actions Inactive

vercel Bot deployed to Preview March 30, 2026 05:52 View deployment

jungcome7 self-assigned this Mar 30, 2026

chatgpt-codex-connector Bot reviewed Mar 30, 2026

View reviewed changes

jungcome7 temporarily deployed to github-pages-preview March 30, 2026 05:57 — with GitHub Actions Inactive

vercel Bot deployed to Preview March 30, 2026 05:58 View deployment

jungcome7 temporarily deployed to github-pages-preview March 30, 2026 06:01 — with GitHub Actions Inactive

vercel Bot deployed to Preview March 30, 2026 06:01 View deployment

jungcome7 temporarily deployed to github-pages-preview March 30, 2026 06:05 — with GitHub Actions Inactive

vercel Bot deployed to Preview March 30, 2026 06:05 View deployment

jungcome7 and others added 6 commits March 30, 2026 15:14

chore: Storybook deploy comment in English

eb8a5cb

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix(design-system): add missing React import in story files

62bf12a

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix(design-system): add missing React import in preview.tsx

2775189

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix(design-system): fix React not defined in Storybook build

0b5f983

Configure Vite esbuild to use classic JSX transform to match tsconfig's jsx: "react" setting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix(design-system): rename Showcase story to Typography for URL consi…

3a8dc7b

…stency Also restore DSTypographyTokensKey reference to match current tokens file. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

jungcome7 force-pushed the roy/ds-storybook branch from bbb7395 to 3a8dc7b Compare March 30, 2026 06:15

jungcome7 temporarily deployed to github-pages-preview March 30, 2026 06:15 — with GitHub Actions Inactive

vercel Bot deployed to Preview March 30, 2026 06:15 View deployment

fix(design-system): update DSTypographyTokensKey → DSTypographySize i…

ff76c83

…n stories Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

jungcome7 temporarily deployed to github-pages-preview March 30, 2026 06:18 — with GitHub Actions Inactive

vercel Bot deployed to Preview March 30, 2026 06:18 View deployment

chatgpt-codex-connector Bot reviewed Mar 30, 2026

View reviewed changes

fix: resolve React 19 dual-instance in Storybook deps

1aa6445

Add react/react-dom resolutions to pin workspace to React 18, preventing yarn from resolving addon-docs peer dep to React 19. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

jungcome7 temporarily deployed to github-pages-preview March 30, 2026 07:15 — with GitHub Actions Inactive

vercel Bot deployed to Preview March 30, 2026 07:15 View deployment

piatoss3612 reviewed Mar 30, 2026

View reviewed changes

fix(design-system): align storySort with renamed Typography story

a7848a6

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

jungcome7 temporarily deployed to github-pages-preview March 30, 2026 07:45 — with GitHub Actions Inactive

vercel Bot deployed to Preview March 30, 2026 07:45 View deployment

piatoss3612 approved these changes Mar 30, 2026

View reviewed changes

jungcome7 merged commit 3392fa5 into develop Mar 30, 2026
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[🎨 Design System] Storybook showcase + theme switching#1904

[🎨 Design System] Storybook showcase + theme switching#1904
jungcome7 merged 9 commits intodevelopfrom
roy/ds-storybook

jungcome7 commented Mar 30, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Mar 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 30, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Mar 30, 2026

Uh oh!

jungcome7 Mar 30, 2026

Uh oh!

jungcome7 commented Mar 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Mar 30, 2026

Uh oh!

jungcome7 Mar 30, 2026

Uh oh!

piatoss3612 Mar 30, 2026

Uh oh!

jungcome7 Mar 30, 2026

Uh oh!

piatoss3612 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jungcome7 commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

추가 수정

Uh oh!

vercel Bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Storybook Deployed

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

jungcome7 Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

jungcome7 commented Mar 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

jungcome7 Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

piatoss3612 Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

jungcome7 Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

piatoss3612 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jungcome7 commented Mar 30, 2026 •

edited

Loading

vercel Bot commented Mar 30, 2026 •

edited

Loading

github-actions Bot commented Mar 30, 2026 •

edited

Loading