feat: upgrade @ledgerhq/hw-transport for Nano Gen5 USB support#1928
Merged
piatoss3612 merged 2 commits intodevelopfrom Apr 21, 2026
Merged
feat: upgrade @ledgerhq/hw-transport for Nano Gen5 USB support#1928piatoss3612 merged 2 commits intodevelopfrom
piatoss3612 merged 2 commits intodevelopfrom
Conversation
- @ledgerhq/hw-transport ^6.31.4 → ^6.35.0 - @ledgerhq/hw-transport-webhid ^6.29.4 → ^6.35.0 - @ledgerhq/hw-transport-webusb ^6.29.4 → ^6.34.0 Latest web transports pull @ledgerhq/devices@8.14.0, which includes Ledger Nano Gen5 in the device registry (productIdMM 0x80, legacyUsbProductId 0x0008). Without this bump, WebHID/WebUSB paths resolve devices@8.4.4 which doesn't know Nano Gen5. Also removes dead @ledgerhq/devices ^6.20.0 from apps/extension (last imported in 03d3f2b via ledgerUSBVendorId, removed during later refactoring, leftover in package.json since 2023). Paired with keplr-mobile-private PR #751 for BLE support.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hw-app-eth@6.42.8 and hw-app-starknet@3.0.1 pull an older hw-transport transitively (^6.31.4 / ^6.31.2) into nested node_modules, which TypeScript treats as a distinct Transport class from the top-level 6.35.0 one — causing TS2345 "Argument of type Transport is not assignable to parameter of type Transport" errors across ledger-grant.tsx, cosmos-ledger-sign.ts, handle-eth-sign.ts, handle-starknet-sign.ts, etc. Adding resolutions["@ledgerhq/hw-transport"] = "^6.35.0" forces a single Transport class identity across the workspace. Same pattern used in keplr-mobile-private for the same reason. Side effect: @ledgerhq/devices also collapses to a single 8.14.0 (previously 6.20.0 / 8.4.4 / 8.14.0 coexisted).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ledgerhq/hw-transport^6.31.4 → ^6.35.0@ledgerhq/hw-transport-webhid^6.29.4 → ^6.35.0@ledgerhq/hw-transport-webusb^6.29.4 → ^6.34.0@ledgerhq/devices^6.20.0 dead dep 제거 (apps/extension/package.json)배경
최신
@ledgerhq/hw-transport-web{hid,usb}는 내부적으로@ledgerhq/devices@8.14.0을 pull하며, 여기devicesList에 Ledger Nano Gen5 (productIdMM: 0x80,legacyUsbProductId: 0x0008)가 추가되어 있음.이 버전 범프 없이는
TransportWebHID.create()/TransportWebUSB.create()경로가devices@8.4.4를 로드하여 Gen5 USB 연결 시 식별 실패.Mobile에서 BLE 지원을 추가한 keplr-mobile-private#751과 페어링되는 Extension 쪽 변경.
업그레이드 후 USB 지원 모델: Nano S, Nano S Plus, Nano X, Stax, Flex, Nano Gen5 (신규)
Dead dep 제거 근거
@ledgerhq/devices: ^6.20.0은 2023-02-11 (커밋03d3f2b58)에ledgerUSBVendorId용도로 추가됐으나, 이후 리팩토링으로 해당 import가 제거되면서package.json선언만 고아 상태로 남아있음. 현재 코드 전체에서 사용처 0건 (grep '@ledgerhq/devices'결과yarn.lock과 dep 선언만 매치), 다른 라이브러리 중 peerDependencies로 요구하는 것도 없음.Test plan
yarn build성공 (extension)Notes
yarn.lock에@ledgerhq/hw-transport@6.31.4(→ devices 8.4.4),@6.20.0(→ devices 6.20.0)가 여전히 병존 —hw-app-eth@6.42.8,hw-app-starknet@3.0.1,hw-transport-mocker,ledger-bitcoin@0.2.3가 caret으로 요구하기 때문. WebHID/WebUSB로 기기를 스캔·식별하는 1차 경로는 모두 8.14.0으로 수렴하므로 Gen5 지원에는 영향 없음. bundle 중복은 변경 전부터 이미 있던 상태.hw-transport싱글톤 통일은 follow-up으로resolutions도입 고려 가능 (Mobile PR #751이 동일 조합 실기기 QA 검증 후 적용 판단).yarn npm audit --severity high: No audit suggestions.🤖 Generated with Claude Code