fix: filter empty scam proposal ids - #52
Open
modernzju wants to merge 8 commits into
Open
Conversation
Chain: cosmos Proposal: #99999999 Domains: synthetic-test.invalid Approved by: U06H5N9D67R
Chain: cosmos Proposal: #1038 Domains: atomplay.at, miro.medium.com, recosmo2.xyz Approved by: U06H5N9D67R
Chain: cosmos Proposal: #1039 Approved by: U06H5N9D67R
Chain: cosmos Proposal: #1040 Domains: cosmos67.at, recosmo7.xyz Approved by: U06H5N9D67R
Chain: cosmos Proposal: #1042 Domains: atomgame.at, blocklist.keplr.app Approved by: U06H5N9D67R
Signed-off-by: modernzju <modernzju@outlook.com>
|
@modernzju is attempting to deploy a commit to the Keplr Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the scam proposal API so it no longer returns empty proposal IDs for files that end with a trailing newline.
What changed
scam-proposals/*.txtWhy
Most proposal list files end with a newline. The previous parsing logic split on
\nbut did not remove empty entries, so the API response could include""as a proposal ID. The scam validators API already filters empty lines, so this makes the proposal API consistent.Testing
git diff --checkscam-proposalsfiles and confirmed no empty proposal IDs are producednpm run lint