Persist transparent enhancement progress - #360
Draft
ValarDragon wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
(this is vibecoded and unreviewed, but affects a user report of slow sync when they haven't logged in in 2 months, but very fast on direct usage of mnemonic) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
completes successfully
Root cause
TransactionsInvolvingAddressrequests were serviced without callingWalletWrite::notify_address_checkedwhen the requested range completed.The wallet DB therefore kept generating the same transparent history requests
on later syncs, causing established wallets to repeatedly download and process
historical transactions after restart or resync.
Impact
Completed transparent-history ranges are now recorded, so subsequent syncs
continue incrementally instead of reprocessing the same history. Partial or
failed streams do not advance the cursor and remain safe to retry.
Validation
cargo fmt -- --checkcargo test sync_engine::enhance::tests(12 passed)cargo test(438 passed, 1 ignored; Docker regtests ignored as designed)No Rust or Dart API surface changes.