This repository was archived by the owner on Jul 2, 2021. It is now read-only.
Accept pathlib.Path type for read_image.#933
Open
sergeant-wizard wants to merge 2 commits intochainer:masterfrom
Open
Accept pathlib.Path type for read_image.#933sergeant-wizard wants to merge 2 commits intochainer:masterfrom
sergeant-wizard wants to merge 2 commits intochainer:masterfrom
Conversation
Contributor
Author
|
Looks like we need to wait for the drop of python 2 support 😭 |
Member
|
FYI: Our policy about py2 support is here. |
Contributor
Author
|
Will ChainerCV update to Chainer 7 after its stable release and then drop Py2 support? |
Member
|
After Chainer v7 becomes stable, we can drop py2 support from ChainerCV. |
Contributor
Author
|
Ok the test should pass once PY2 test is removed. I'll rebase once that
happens.
…On Tue, Oct 8, 2019, 4:51 PM Toru Ogawa ***@***.***> wrote:
After Chainer v7 becomes stable, we can drop py2 support from ChainerCV.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#933?email_source=notifications&email_token=ABOL4ZDGUBQKGYDP5SNVT6DQNUMHZA5CNFSM4I6WDEOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAV7JFQ#issuecomment-539751574>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABOL4ZHLXI6XHTKSZ4LVYDDQNUMHZANCNFSM4I6WDEOA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch enables users to pass a
pathlib.Pathobject toread_image, which is currently not possible due to the limitationscv2.imread(cv2.imread(pathlib.Path('hoge.png'))throws a cryptic error )