Combine and improve chainctl images pages #2250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ornate-narwhal-088216 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
erikaheidi
reviewed
May 7, 2025
|
I reviewed the content just in case, had only one comment to add. Will defer the approval to @ltagliaferri / @smythp because of the redirect question. |
ltagliaferri
requested changes
May 8, 2025
ltagliaferri
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/chainguard-dev/internal/issues/4724 by transforming the images page from more of a reference to something more like a short tutorial.
This also deletes a page dedicated to the
chainctl images historysub-command and inserts the information into the main page. Does this one need a redirect, @smythp and @ltagliaferri ? The history page was released with a bit of fanfare as a cooperative effort and I would hate to unnecessarily lose the goodwill. At the same time, it really doesn't need it's own page.