Skip to content

Revert "Fail build when var-transforms produce empty or non-matching results" #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sil2100 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Revert "Fail build when var-transforms produce empty or non-matching results" #2172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions pkg/config/vars.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,7 @@ func (cfg Configuration) PerformVarSubstitutions(nw map[string]string) error {
return fmt.Errorf("match value: %s string does not compile into a regex: %w", v.Match, err)
}

// Check if the regex matches at all
if !re.MatchString(from) {
return fmt.Errorf("var-transform %q failed: regex %q does not match input %q (no substitution will be performed)", v.To, v.Match, from)
}

output := re.ReplaceAllString(from, v.Replace)
if output == "" {
return fmt.Errorf("var-transform %q resulted in empty value (from=%q, match=%q, replace=%q) - transformed variables cannot be empty", v.To, from, v.Match, v.Replace)
}
nw[nk] = output
}

Expand Down
156 changes: 0 additions & 156 deletions pkg/config/vars_test.go
View file
Open in desktop

This file was deleted.

Loading