Skip to content

Limit architectures specified in example#2335

Open
codysoyland wants to merge 1 commit intomainfrom
fix-example-arch
Open

Limit architectures specified in example#2335
codysoyland wants to merge 1 commit intomainfrom
fix-example-arch

Conversation

@codysoyland
Copy link

Melange Pull Request Template

This limits the architectures specified in the example to just arm64 and x86_64. This speeds up the build and removes arches not supported by wolfi.

Fixes #2329

Functional Changes

  • This change can build all of Wolfi without errors (describe results in notes)

Notes:

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes:

Linter

  • The new check is clean across Wolfi
  • The new check is opt-in or a warning

Notes:

@xnox
Copy link
Member

xnox commented Feb 6, 2026

The example hunk is good.

Not sure I understand the e2e workflow change. What issue are you trying to address with the e2e workflow change?

@codysoyland
Copy link
Author

Not sure I understand the e2e workflow change. What issue are you trying to address with the e2e workflow change?

Sorry, I meant to come back and update this after CI ran -- the intent with the e2e workflow was so that we would catch this error if the architecture section is removed from the example workflow (the workflow sets the architecture explicitly and removing that causes it to break as I observed when trying to run the example manually).

I will actually back out that workflow change as I broke the workflow as it references several other unrelated examples that I would rather not touch and this is unlikely to become a regression.

The example fails to build due to unsupported architectures.

Signed-off-by: Cody Soyland <cody.soyland@chainguard.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Example fails to build

2 participants

Comments