license-check: add distinctive deep/shallow modes of license scanning#2350
Merged
89luca89 merged 4 commits intochainguard-dev:mainfrom Feb 18, 2026
Merged
license-check: add distinctive deep/shallow modes of license scanning#235089luca89 merged 4 commits intochainguard-dev:mainfrom
89luca89 merged 4 commits intochainguard-dev:mainfrom
Conversation
Signed-off-by: Łukasz 'sil2100' Zemczak <lukasz.zemczak@chainguard.dev>
Signed-off-by: Łukasz 'sil2100' Zemczak <lukasz.zemczak@chainguard.dev>
89luca89
approved these changes
Feb 17, 2026
89luca89
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now license-check goes through the whole source tree trying to locate license files. This is good, but not really practical. For projects with a lot of vendored modules, this causes an explosion of licenses. Those licenses are important, yes, but just requesting their addition to our melange yaml file results in unreadable, bloated melange files that require constant maintenance. So let's introduce a
--scan-typeargument and for now default toshallow, which will only try to find the main top-most license of the project. We need a better scheme to support the rest, possibly by just running an external tool while creating the SBOM.