feat: Support multiple --env-file options#2355
Merged
dannf merged 1 commit intochainguard-dev:mainfrom Feb 18, 2026
Merged
Conversation
d9d3620 to
3816e41
Compare
3816e41 to
42d5901
Compare
89luca89
previously approved these changes
Feb 18, 2026
Contributor
|
LGTM just a couple of lint nits about the docs |
42d5901 to
1f35f24
Compare
I need a way to inject more environment variables into the build. melange supports a --env-file for specifying environment variables. Wolfi builds already use this parameter to pass static, arch-specific variables in. Specifying a second --env-file nullifies the first. Let's allow multiple --env-file options, with each subsequent --env-file overlaying values on top of the previous ones. Note that if any users were relying on the previous behavior of subsequent `--env-file` options nullifying all earlier ones, this would break that use case. Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
1f35f24 to
90c20b9
Compare
89luca89
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need a way to inject more environment variables into the build.
melange supports a --env-file for specifying environment variables.
Wolfi builds already use this parameter to pass static, arch-specific
variables in. Specifying a second --env-file nullifies the first.
Let's allow multiple --env-file options, with each subsequent --env-file
overlaying values on top of the previous ones.
Note that if any users were relying on the previous behavior of subsequent
--env-fileoptions nullifying all earlier ones, this would break thatuse case.
Signed-off-by: dann frazier dann.frazier@chainguard.dev