Add constructor accepting both TxSignService and TransactionReceiptPr… #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocessor in RawTransactionManager and FastRawTransactionManager
nilevols
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
What does this PR do?
This PR adds missing constructors to both RawTransactionManager and FastRawTransactionManager classes that accept both TxSignService and TransactionReceiptProcessor parameters.
Where should the reviewer start?
The reviewer should examine the changes in:
core/src/main/java/org/web3j/tx/RawTransactionManager.java - Added a constructor accepting both TxSignService and TransactionReceiptProcessor
core/src/main/java/org/web3j/tx/FastRawTransactionManager.java - Added a constructor accepting both TxSignService and TransactionReceiptProcessor
Why is it needed?
Before this PR, users had to choose between using a custom TxSignService or a custom TransactionReceiptProcessor, but couldn't use both simultaneously. This enhancement provides greater flexibility for configuring transaction managers, allowing users to:
Customize how transactions are signed (via TxSignService)
Customize how transaction receipts are processed (via TransactionReceiptProcessor)
Do both at the same time
This is especially valuable for users with custom transaction signing requirements (such as HSM integration) who also need control over transaction receipt processing.