Skip to content

feat: EIP-712 typed messages for improved lcp security council admin privileges#3166

Open
ercecan wants to merge 54 commits into
needs-auditfrom
erce/eip712-typed-messages
Open

feat: EIP-712 typed messages for improved lcp security council admin privileges#3166
ercecan wants to merge 54 commits into
needs-auditfrom
erce/eip712-typed-messages

Conversation

@ercecan

@ercecan ercecan commented Feb 27, 2026

Copy link
Copy Markdown
Member

Description

Main pr for the new lcp security council admin privileges

Linked Issues

  • Fixes # (issue, if applicable)
  • Related to # (issue)

Testing

Describe how these changes were tested. If you've added new features, have you added unit tests?

Docs

Describe where this code is documented. If it changes a documented interface, have the docs been updated?

@github-actions

Copy link
Copy Markdown

⚠️ Changelog entry missing

No changes detected in CHANGELOG.md.

Recommendation:

feat: eip712 typed messages

Please add an entry to the CHANGELOG.md or dismiss this if the change doesn't require documentation.

To dismiss: Reply with /skip-changelog in any comment.

@ercecan ercecan self-assigned this Feb 27, 2026
Comment thread crates/light-client-prover/src/circuit/initial_values.rs Outdated
@ercecan ercecan changed the base branch from erce/use-address-instead-of-pubkeys-for-security-council to needs-audit March 2, 2026 14:24
@ercecan ercecan changed the title feat: eip712 typed messages feat: EIP-712 typed messages for improved lcp security council admin privileges Mar 2, 2026
# Description


## Linked Issues
- Fixes # (issue, if applicable)
- Related to # (issue) 

## Testing
Describe how these changes were tested. If you've added new features,
have you added unit tests?

## Docs
Describe where this code is documented. If it changes a documented
interface, have the docs been updated?
@codecov

codecov Bot commented Mar 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.98601% with 126 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (needs-audit@49ddad6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/light-client-prover/src/circuit/mod.rs 90.6% 44 Missing ⚠️
.../light-client-prover/src/circuit/initial_values.rs 35.0% 37 Missing ⚠️
...ht-client-prover/src/circuit/method_id_verifier.rs 90.3% 16 Missing ⚠️
...ight-client-prover/src/circuit/security_council.rs 89.1% 9 Missing ⚠️
...reign-sdk/rollup-interface/src/state_machine/da.rs 55.0% 9 Missing ⚠️
...rates/light-client-prover/src/circuit/accessors.rs 98.2% 5 Missing ⚠️
crates/bitcoin-da/src/verifier.rs 0.0% 3 Missing ⚠️
...ates/sovereign-sdk/adapters/mock-da/src/service.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/bitcoin-da/src/helpers/backup.rs 85.8% <100.0%> (ø)
...s/bitcoin-da/src/helpers/builders/body_builders.rs 100.0% <ø> (ø)
crates/bitcoin-da/src/helpers/mod.rs 93.1% <100.0%> (ø)
crates/bitcoin-da/src/helpers/parsers.rs 89.7% <100.0%> (ø)
crates/bitcoin-da/src/service.rs 84.0% <100.0%> (ø)
crates/bitcoin-da/src/tx_signer.rs 94.6% <100.0%> (ø)
crates/light-client-prover/src/da_block_handler.rs 97.8% <100.0%> (ø)
crates/light-client-prover/src/rpc.rs 98.8% <100.0%> (ø)
crates/bitcoin-da/src/verifier.rs 77.4% <0.0%> (ø)
...ates/sovereign-sdk/adapters/mock-da/src/service.rs 92.8% <0.0%> (ø)
... and 6 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ercecan ercecan added HOLD-MERGE PR is not draft but should not be merged yet labels Mar 16, 2026
ercecan added 2 commits March 26, 2026 17:20
# Description
Consumes nonce on failed messages like evm does on reverted txs
# Description
Sort sc messages by nonce and process them latest
Comment thread crates/bitcoin-da/src/helpers/backup.rs Outdated
Comment thread crates/light-client-prover/src/circuit/accessors.rs Outdated
Comment thread crates/light-client-prover/src/circuit/method_id_verifier.rs Outdated
Comment thread crates/light-client-prover/src/circuit/mod.rs Outdated
Comment thread crates/light-client-prover/src/circuit/mod.rs
Comment thread bin/citrea/tests/bitcoin/light_client_test.rs
Comment thread bin/citrea/tests/bitcoin/light_client_test.rs
Comment thread bin/citrea/tests/bitcoin/light_client_test.rs
Comment thread bin/citrea/tests/bitcoin/light_client_test.rs Outdated
Comment thread crates/light-client-prover/src/tests/test_utils.rs Outdated
ercecan and others added 14 commits April 6, 2026 16:36
# Description


## Linked Issues
- Fixes # (issue, if applicable)
- Related to # (issue) 

## Testing
Describe how these changes were tested. If you've added new features,
have you added unit tests?

## Docs
Describe where this code is documented. If it changes a documented
interface, have the docs been updated?
@ercecan ercecan requested review from exeokan, eyusufatik and jfldde April 7, 2026 13:17
Comment thread crates/light-client-prover/src/circuit/accessors.rs
Comment thread crates/light-client-prover/src/circuit/mod.rs
@ercecan ercecan requested a review from exeokan April 8, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HOLD-MERGE PR is not draft but should not be merged yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants