fix(bitcoin-da): propagate get_block_info error in determine_tx_status instead of .unwrap_or(0)#3263
Open
amathxbt wants to merge 2 commits into
Conversation
…s instead of defaulting to 0 Using .unwrap_or(0) silently sets block_height to 0 when get_block_info fails for a confirmed transaction, corrupting the monitored status with a false genesis-block height. Propagate the error with ? instead.
jfldde
previously approved these changes
May 5, 2026
eyusufatik
previously approved these changes
May 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
Member
|
run lint-fix please |
Author
|
Done! Ran the method chain in |
Author
|
@jfldde @eyusufatik lint-fix was applied in a previous commit. Ready for re-review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3262
Problem
.unwrap_or(0)onget_block_infoindetermine_tx_statussilently usesblock_height: 0on RPC failures, corrupting finality calculations.Fix
Replace with
.await?.height as u64;to propagate the error.