feat: Toggle rpc listen mode to producer sequencer#3295
Open
ercecan wants to merge 8 commits into
Open
Conversation
ercecan
changed the title
|
jfldde
reviewed
Jun 9, 2026
Comment on lines
+62
to
+65
| const MAIN_SEQUENCER_PROBE_ATTEMPTS: u32 = 5; | ||
| /// Delay between consecutive main sequencer probes. | ||
| const MAIN_SEQUENCER_PROBE_INTERVAL: Duration = Duration::from_secs(2); | ||
| /// Per-probe request timeout when checking the main sequencer. |
Contributor
There was a problem hiding this comment.
As in, if we know for a fact that the sequencer is down/crashed, we still need to wait on these 10seconds ?
jfldde
reviewed
Jun 9, 2026
| "Conversion to producer failed: {reason}" | ||
| ))) | ||
| } | ||
| Err(e) => Err(internal_rpc_error(format!( |
Contributor
There was a problem hiding this comment.
Is that the path on listen mode sequencer shutdown ? If not, we should reset started to false as well
Contributor
There was a problem hiding this comment.
Maybe a semaphore of 1 would have been less error prone instead of having to reset started
jfldde
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rpc method to toggle the switch to producer sequencer from listen mode sequencer