Skip to content

Website: Add a short project description in HTML#144

Open
samuel-duhaime wants to merge 1 commit into
chairemobilite:mainfrom
samuel-duhaime:addHTMLWebsitePrototype
Open

Website: Add a short project description in HTML#144
samuel-duhaime wants to merge 1 commit into
chairemobilite:mainfrom
samuel-duhaime:addHTMLWebsitePrototype

Conversation

@samuel-duhaime

@samuel-duhaime samuel-duhaime commented May 29, 2026

Copy link
Copy Markdown
Contributor

PR

Note: we might not push this PR, we just want to implement something like that in the Chaire Mobilite website.

  • Don't push. Just review the content.

Description

Website: Add a short project description in HTML

  • Created index.html with bilingual content (French and English) for the localisation tool.
  • Included images for government funding in both languages.
  • Implemented JavaScript for language preference storage and switching.

Summary by CodeRabbit

  • New Features
    • Launched a new bilingual landing page supporting French and English
    • Added language switcher to easily toggle between available languages
    • Automatic language detection from browser preferences on first visit
    • User language preferences are remembered across sessions
    • Includes localized project links and region-appropriate imagery

Review Change Stack

- Created index.html with bilingual content (French and English) for the localisation tool.
- Included images for government funding in both languages.
- Implemented JavaScript for language preference storage and switching.
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8b5b0324-3840-4d68-81c5-f4fdd13b3e21

📥 Commits

Reviewing files that changed from the base of the PR and between 2556ecd and d691213.

⛔ Files ignored due to path filters (2)
  • localisation/src/assets/images/fundedByGoC_en_black.png is excluded by !**/*.png
  • localisation/src/assets/images/fundedByGoC_fr_black.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • localisation/src/assets/index.html
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: code-lint
  • GitHub Check: check-format
  • GitHub Check: build-and-test (24.x)
  • GitHub Check: pr-build-check
🔇 Additional comments (4)
localisation/src/assets/index.html (4)

1-68: LGTM!


70-74: LGTM!


198-229: LGTM!


129-134: Referenced GoC funder images exist.

  • localisation/src/assets/images/fundedByGoC_fr_black.png (used at 129-134)
  • localisation/src/assets/images/fundedByGoC_en_black.png (used at 189-194)

Walkthrough

This PR adds a new bilingual landing page (localisation/src/assets/index.html) with French and English content sections. The page includes a language switcher UI, language-specific images and text, and links to related projects. Client-side JavaScript detects the user's preferred language from localStorage or browser settings, updates the DOM to show the correct language section, and persists the choice to storage.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • kaligrafy
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title describes adding a project description in HTML, which aligns with the PR's intent to add a bilingual landing page prototype, though it understates the actual scope (language switcher, localStorage persistence, multi-section layout).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant