fix: add error logging to empty catch blocks#1794
Open
gugli4ifenix-design wants to merge 1 commit into
Open
Conversation
5 files with silent error swallowing: - httpClient.ts: response parsing errors hidden - mermaidRenderer.tsx: render failures invisible - editor/index.tsx: editor errors suppressed - ShowText/index.tsx: parse errors silenced Adds console.warn to make errors visible during development while preserving existing fail-safe behavior. Found during a static analysis of 97 popular open source projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
6 empty catch blocks across 5 files silently swallow errors:
httpClient.ts(×2): Response parsing errors are invisible — if the server returns malformed JSON,datasilently staysundefinedmermaidRenderer.tsx: Mermaid diagram render failures are hiddeneditor/index.tsx(×2): Editor errors are suppressedShowText/index.tsx: Content parse errors are silencedFix
Add
console.warnto all empty catch blocks:Found during a static analysis sweep of 97 popular open source projects.