feature(veinmind-runner): add harbor webhook #113
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tsuki124
reviewed
Jul 29, 2022
| engine := s.registerRouter() | ||
|
|
||
| go func() { | ||
| err := engine.Run(":" + s.option.port) |
Contributor
There was a problem hiding this comment.
这里可以直接 engine.RunListener(s.option.listener)
| log.Error(err) | ||
| return | ||
| } | ||
| postData, err := route.ParseHarborwebhookPostdata(c) |
Contributor
There was a problem hiding this comment.
考虑下方法的入参，尽量做到通用，这里可能[]byte比较合适
| } | ||
| val, ok := s.option.policies.Load(postData.Type) | ||
| if !ok { | ||
| log.Error(err) |
| } | ||
|
|
||
| func (s *harborWebhookServer) registerRouter() *gin.Engine { | ||
| engine := gin.Default() |
|
|
||
| func (s *harborWebhookServer) registerRouter() *gin.Engine { | ||
| engine := gin.Default() | ||
| engine.POST("/api", func(c *gin.Context) { |
Contributor
There was a problem hiding this comment.
路由层里不要加业务逻辑代码，拆分直接传给业务层处理
Collaborator
|
duplicate #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.