fix: handle numeric number input set value#3170
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 63d959f The changes in this PR will be included in the next version bump. This PR includes changesets to release 86 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1adf8c0 to
34b77e0
Compare
34b77e0 to
cd754ab
Compare
cd754ab to
63d959f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3169
📝 Description
Fix number input
api.setValuewhenformatOptionsis defined.⛳️ Current behavior (updates)
Calling
api.setValuewith a number could pass the numeric value into the localized number parser, which expects a string and can throw.🚀 New behavior
Numeric
setValuearguments are treated as raw numbers before formatting, while string values continue through the localized parser.💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
Added a patch changeset for
@zag-js/number-input.Verified with:
pnpm exec vitest packages/machines/number-input/tests --runpnpm --filter @zag-js/number-input typecheckpnpm --filter @zag-js/number-input lint