Skip to content

fix: handle numeric number input set value#3170

Merged
segunadebayo merged 1 commit into
mainfrom
cursor/fix-number-input-set-value-49eb
Jun 9, 2026
Merged

fix: handle numeric number input set value#3170
segunadebayo merged 1 commit into
mainfrom
cursor/fix-number-input-set-value-49eb

Conversation

@segunadebayo

@segunadebayo segunadebayo commented Jun 8, 2026

Copy link
Copy Markdown
Member

Closes #3169

📝 Description

Fix number input api.setValue when formatOptions is defined.

⛳️ Current behavior (updates)

Calling api.setValue with a number could pass the numeric value into the localized number parser, which expects a string and can throw.

🚀 New behavior

Numeric setValue arguments are treated as raw numbers before formatting, while string values continue through the localized parser.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Added a patch changeset for @zag-js/number-input.

Verified with:

  • pnpm exec vitest packages/machines/number-input/tests --run
  • pnpm --filter @zag-js/number-input typecheck
  • pnpm --filter @zag-js/number-input lint
Open in Web Open in Cursor 

@changeset-bot

changeset-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 63d959f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 86 packages
Name Type
@zag-js/number-input Patch
@zag-js/anatomy-icons Patch
@zag-js/anatomy Patch
@zag-js/core Patch
@zag-js/docs Patch
@zag-js/preact Patch
@zag-js/react Patch
@zag-js/solid Patch
@zag-js/svelte Patch
@zag-js/vanilla Patch
@zag-js/vue Patch
@zag-js/accordion Patch
@zag-js/angle-slider Patch
@zag-js/async-list Patch
@zag-js/avatar Patch
@zag-js/carousel Patch
@zag-js/cascade-select Patch
@zag-js/checkbox Patch
@zag-js/clipboard Patch
@zag-js/collapsible Patch
@zag-js/color-picker Patch
@zag-js/combobox Patch
@zag-js/date-input Patch
@zag-js/date-picker Patch
@zag-js/dialog Patch
@zag-js/drawer Patch
@zag-js/editable Patch
@zag-js/file-upload Patch
@zag-js/floating-panel Patch
@zag-js/hover-card Patch
@zag-js/image-cropper Patch
@zag-js/listbox Patch
@zag-js/marquee Patch
@zag-js/menu Patch
@zag-js/navigation-menu Patch
@zag-js/pagination Patch
@zag-js/password-input Patch
@zag-js/pin-input Patch
@zag-js/popover Patch
@zag-js/presence Patch
@zag-js/progress Patch
@zag-js/qr-code Patch
@zag-js/radio-group Patch
@zag-js/rating-group Patch
@zag-js/scroll-area Patch
@zag-js/select Patch
@zag-js/signature-pad Patch
@zag-js/slider Patch
@zag-js/splitter Patch
@zag-js/steps Patch
@zag-js/switch Patch
@zag-js/tabs Patch
@zag-js/tags-input Patch
@zag-js/timer Patch
@zag-js/toast Patch
@zag-js/toc Patch
@zag-js/toggle-group Patch
@zag-js/toggle Patch
@zag-js/tooltip Patch
@zag-js/tour Patch
@zag-js/tree-view Patch
@zag-js/store Patch
@zag-js/types Patch
@zag-js/aria-hidden Patch
@zag-js/auto-resize Patch
@zag-js/collection Patch
@zag-js/color-utils Patch
@zag-js/utils Patch
@zag-js/date-utils Patch
@zag-js/dismissable Patch
@zag-js/dom-query Patch
@zag-js/file-utils Patch
@zag-js/focus-trap Patch
@zag-js/focus-visible Patch
@zag-js/highlight-word Patch
@zag-js/hotkeys Patch
@zag-js/i18n-utils Patch
@zag-js/interact-outside Patch
@zag-js/json-tree-utils Patch
@zag-js/live-region Patch
@zag-js/popper Patch
@zag-js/rect-utils Patch
@zag-js/remove-scroll Patch
@zag-js/scroll-snap Patch
@zag-js/stringify-state Patch
svelte-kit-starter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jun 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
zag-nextjs Ready Ready Preview Jun 9, 2026 10:57am
zag-solid Ready Ready Preview Jun 9, 2026 10:57am
zag-svelte Ready Ready Preview Jun 9, 2026 10:57am
zag-vue Ready Ready Preview Jun 9, 2026 10:57am
zag-website Ready Ready Preview Jun 9, 2026 10:57am

Request Review

@cursor cursor Bot force-pushed the cursor/fix-number-input-set-value-49eb branch from 1adf8c0 to 34b77e0 Compare June 8, 2026 23:08
@segunadebayo segunadebayo marked this pull request as ready for review June 9, 2026 10:47
@cursor cursor Bot force-pushed the cursor/fix-number-input-set-value-49eb branch from 34b77e0 to cd754ab Compare June 9, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

api.setValue in NumberInput component throws when formatOptions prop is defined

1 participant