feat(examples): complete preact examples to align with other frameworks#3175
Draft
segunadebayo wants to merge 4 commits into
Draft
feat(examples): complete preact examples to align with other frameworks#3175segunadebayo wants to merge 4 commits into
segunadebayo wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
- Sync all 215 example pages from React examples with @zag-js/preact - Add component index page and navigation matching React/Solid patterns - Copy shared hooks, components, and lib utilities from next-ts - Add sync-preact-examples script for future maintenance - Add start-preact command and missing dependencies - Adapt tabs/with-link and dialog/cloudinary for Vite/Preact
- Remove scripts/sync-preact-examples.ts per request - Add smoke tests for all 215 example routes - Add preact to Playwright config and e2e-preact script - Fix @zag-js/preact compact() and normalize-props to match React behavior - Add E2E-only pages: dialog/nested, combobox/form, date-picker/min-max, drawer/draggable-false
cursor
Bot
force-pushed
the
cursor/complete-preact-examples-656a
branch
from
bd355c1 to
c3bac96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings the Preact examples app to parity with the React examples by syncing all 215 shared example routes, matching the navigation and app shell patterns used by React and Solid.
Current behavior
The Preact examples app only had 4 working examples with most routes commented out, incorrect branding ("Zag.js + Solid"), and no
start-preactscript.New behavior
@zag-js/sharedroutes are available inexamples/preact-ts/:component)pnpm start-preactandpnpm e2e-preactcommands addede2e/examples-smoke.e2e.ts) verify all 215 routes load without runtime errors@zag-js/preactfixes to match React behavior:compact()on machine props, stop mappingdefaultValue/defaultCheckedto controlled propsdialog/nested,combobox/form,date-picker/min-max,drawer/draggable-falsetabs/with-linkanddialog/cloudinaryTesting
FRAMEWORK=preactIs this a breaking change?
No