Skip to content

Conversation

h3rmanj
Copy link
Contributor

@h3rmanj h3rmanj commented May 21, 2025

closes #465

Fixes both cases described in the issue:

  • Custom publish script that does not create tag errors

    This case happens when you have a custom release script, instead of running changeset tag or changeset version, that does not create tags locally, but only prints New version: to force changeset to still create a release (which would implicitly create a tag as well). Not sure how they ended up with that solution though, maybe it predates the changeset tag command?

    Fixed by passing ignoreReturnCode: true when pushing the tag. Not sure if this can have some pitfalls if an error is returned for other reasons though.

  • createGithubReleases: false does not push tags

    In Introduce an option to use the GitHub API to commit changes, for GPG #391, pushing tags was moved from always happening, to only happening if createGithubReleases is true. https://github.com/changesets/action/pull/391/files#diff-69c9100f2a3041c22e8fddf77d13fd7eb1aa42a8a200aa35a81ea589c135e66aL133

    Fixed by moving the createGithubReleases if-statement to only affect actually creating a github release.

Copy link

changeset-bot bot commented May 21, 2025

🦋 Changeset detected

Latest commit: cecbdcd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/action Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@shrugs
Copy link

shrugs commented Aug 19, 2025

please merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1.5.0 in default commitMode is breaking on tag push

2 participants