fix: tags in git-cli
commit mode
#500
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #465
Fixes both cases described in the issue:
Custom
publish
script that does not create tag errorsThis case happens when you have a custom release script, instead of running
changeset tag
orchangeset version
, that does not create tags locally, but only printsNew version:
to force changeset to still create a release (which would implicitly create a tag as well). Not sure how they ended up with that solution though, maybe it predates thechangeset tag
command?Fixed by passing
ignoreReturnCode: true
when pushing the tag. Not sure if this can have some pitfalls if an error is returned for other reasons though.createGithubReleases: false
does not push tagsIn Introduce an option to use the GitHub API to commit changes, for GPG #391, pushing tags was moved from always happening, to only happening if
createGithubReleases
is true. https://github.com/changesets/action/pull/391/files#diff-69c9100f2a3041c22e8fddf77d13fd7eb1aa42a8a200aa35a81ea589c135e66aL133Fixed by moving the
createGithubReleases
if-statement to only affect actually creating a github release.