Handle error when pushing git tags with the git CLI - #735
Open
bluwy wants to merge 3 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 077c356 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
beeequeue
reviewed
Sep 4, 2026
| } | ||
| } catch (err) { | ||
| // Assuming tag was manually pushed in custom publish script | ||
| core.warning(`Failed to create tag ${tag}: ${(err as Error).message}`); |
Member
There was a problem hiding this comment.
should we state this assumption in the message as well?
Member
Author
There was a problem hiding this comment.
Yeah I think we can add it. I'll make the change
beeequeue
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #201
The GitHub API also handle the error if it fails, so I don't see why the git CLI path also wouldn't