Skip to content

Commit

Permalink
Integrate bezier-vscode publish to changeset publish (#2573)
Browse files Browse the repository at this point in the history
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue

<!-- Please link to issue if one exists -->

<!-- Fixes #0000 -->

- resolves #2572 

## Summary

<!-- Please brief explanation of the changes made -->

- bezier vscode 익스텐션 배포를 changeset PR이 머지될 때 수행하도록 합니다. 

## Details

<!-- Please elaborate description of the changes -->

- changesets액션은 changeset이 있다면 changeset PR을 만들고, 없다면 publish 옵션으로 준
yarn release 커맨드를 실행합니다. yarn release 커맨드 시점에 익스텐션 배포까지 넣어버리는게 좋을 것 같아서
이렇게 했습니다.

### Breaking change? (Yes/No)

<!-- If Yes, please describe the impact and migration path for users -->

- No

## References

<!-- Please list any other resources or points the reviewer should be
aware of -->

- None
  • Loading branch information
yangwooseong authored Dec 19, 2024
1 parent bc0c694 commit df16d33
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,4 @@ jobs:
# https://github.com/changesets/action/issues/187
GITHUB_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

- name: Release VS Code extension
run: yarn build --filter=bezier-vscode && yarn workspace bezier-vscode publish
env:
VSCE_PAT: ${{ secrets.VSCE_PERSONAL_ACCESS_TOKEN }}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"test": "turbo run test",
"clean": "turbo run clean && rm -rf node_modules .turbo",
"version-packages": "changeset version && yarn --mode=\"update-lockfile\"",
"release": "turbo run build --filter='@channel.io/*' && changeset publish",
"release": "turbo run build --filter='@channel.io/*' && changeset publish && yarn workspace bezier-vscode publish",
"update-snapshot": "yarn workspace @channel.io/bezier-react update-snapshot",
"changeset": "changeset",
"postinstall": "husky install",
Expand Down

0 comments on commit df16d33

Please sign in to comment.