fix: fix errors on apiv2 schema updates #467
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manasaV3
reviewed
Mar 20, 2025
| update-schema: codegen alembic-autogenerate alembic-upgrade-head | ||
| # $(docker_compose_run) $(CONTAINER) ruff check --fix . | ||
| $(docker_compose_run) $(APP_CONTAINER) sh -c 'strawberry export-schema main:schema > /app/graphql_api/schema.graphql' | ||
| linkml generate erdiagram --structural --classes Alignment --classes AnnotationAuthor --classes AnnotationFile --classes AnnotationShape --classes Annotation --classes DatasetAuthor --classes DatasetFunding --classes Dataset --classes DepositionAuthor --classes Deposition --classes Frame --classes PerSectionAlignmentParameters --classes AnnotationMethodLink --classes GainFile --classes FrameAcquisitionFile --classes Run --classes Tiltseries --classes PerSectionParameters --classes TomogramAuthor --classes TomogramVoxelSpacing --classes Tomogram schema/schema.yaml> schema/README.md |
manasaV3
reviewed
Mar 20, 2025
Makefile
Outdated
| .PHONY: update-api-schema | ||
| update-api-schema: | ||
| $(MAKE) -C apiv2 update-schema | ||
| pre-commit run --all-files |
Contributor
There was a problem hiding this comment.
This might not be needed for --all-files when only files inside apiv2 would have changed.
Also, should this be a part of the make command for apiv2?
Contributor
Author
There was a problem hiding this comment.
ohhh I didn't realize we can run pre-commit from subdirectories!
Contributor
Author
There was a problem hiding this comment.
wait actually it is part of that make target. It looks like pre-commit behaves differently when run from inside vs outside the apiv2 directory
Bento007
approved these changes
Apr 15, 2025
# Conflicts: # apiv2/schema/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr does a couple things: