Add Aurora deletion protection variable #116
Conversation
| @@ -50,6 +50,7 @@ resource "aws_rds_cluster" "db" { | |||
| kms_key_id = "${var.kms_key_id}" | |||
| port = "${var.port}" | |||
| db_cluster_parameter_group_name = "${aws_rds_cluster_parameter_group.db.id}" | |||
| deletion_protection = "${var.db_deletion_protection}" | |||
There was a problem hiding this comment.
defaulting this to true might break some of the tests in this repo, the tests might need to specify a false
There was a problem hiding this comment.
hmm I'll change the default to false then, since I need this one now. But I think deletion protection should be true by default.
There was a problem hiding this comment.
I'll change it if the tests fail
There was a problem hiding this comment.
yeah, i think deletion protection can stay true, but the terraform in the tests need to specify false
There was a problem hiding this comment.
There was a problem hiding this comment.
you might also need to go manually delete these databases since the test will probably not be able to delete them
There was a problem hiding this comment.
I deleted the stale databases. I can't find a quick way to set the boolean to false in the test though, I'll leave it to default for now.
No description provided.