[feature] Add 'snapshot_identifier' to all aws-aurora modules #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will support creating a new RDS cluster from an existing snapshot, e.g. for data mirroring to a different env.
cziie
reviewed
Jul 8, 2021
| description = "Specifies whether or not to create this cluster from a snapshot. You can use either the name or ARN when specifying a DB cluster snapshot, or the ARN when specifying a DB snapshot." | ||
| default = null | ||
| } | ||
|
|
||
| variable "skip_final_snapshot" { |
There was a problem hiding this comment.
📝 [tflint] reported by reviewdog 🐶skip_final_snapshot variable has no description
| description = "Specifies whether or not to create this cluster from a snapshot. You can use either the name or ARN when specifying a DB cluster snapshot, or the ARN when specifying a DB snapshot." | ||
| default = null | ||
| } | ||
|
|
||
| variable "skip_final_snapshot" { |
There was a problem hiding this comment.
skip_final_snapshot variable has no type
alexsmaliy-czi
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will support creating a new RDS cluster from an existing snapshot, e.g. for data mirroring to a different env.
If snapshot_identifier not provided, should revert to original behavior.
This takes functionality from a side branch of @atolopko-czi and puts it into the main branch, since there is already code that relies on this functionality.